deps: clear the last of the Dependabot backlog - #117
Merged
Conversation
fluentcart-mcp takes @types/node 24.13.3 -> 26.1.2. thank-you takes vue 3.5.29 -> 3.5.40, vue-router 5.0.3 -> 5.2.0 and vue-tsc 2.2.12 -> 3.3.9. portal-extender takes vue 3.5.29 -> 3.5.40, element-plus 2.13.3 -> 2.14.3 and vue-router 4.6.4 -> 5.2.0, so its bundle hashes churn; the enqueue reads .vite/manifest.json at runtime, and the manifest still has the shape AdminMenu.php expects. Three reverted, each because the fix would mean editing config rather than a version. typescript 7 breaks vue-tsc outright in thank-you (ERR_PACKAGE_PATH_NOT_EXPORTED on ./lib/tsc, a crash rather than a type error) and fails the MCP build on a removed compiler option. biome 2.5.7 refuses thank-you's v1 schema. All three want their own change. Gates: MCP 2823 unit and 404/405 tooling, the one failure being the stale gitignored dist-packages fixture. thank-you builds and passes 23/23 phpunit; its typecheck and biome failures were reproduced on the unmodified tree first. portal-extender builds.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The release contract pins a source-tree digest and the MCPB manifest embeds the same one, so a dependency change stales both and the package gate refuses the branch. One line each, digest only — 291 tools, 20 categories and 25 advertised tools all unchanged, and versions.json still agrees with the contract. Third time tonight this pair has needed regenerating after a dependency move. It is doing its job each time; it is just not something a bump can be finished without.
|
Review Summary Dependency-only bump across three workspaces — no application logic changes. The Vite manifest for portal-extender is read at runtime ( Issues: 0 blocking, 0 suggestions, 0 nits No issues found — this looks solid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four PRs that survived the supersession sweep. Three taken, one rejected on evidence.
Taken
fluentcart-mcp@types/nodefchub-thank-youvue/vue-router/vue-tscfchub-portal-extendervue/element-plus/vue-routerportal-extender's bundle hashes churn as a result. Safe: the enqueue reads
assets/dist/.vite/manifest.jsonat runtime rather than hardcoding names, and the manifest still carries the shapeAdminMenu.phpreads.Rejected — and this one matters
@base-ui/react1.2.0 → 1.7.0 (#115) breaks the docs deploy. Not a type error, a failed build:I tested it in the container that actually produces the deployed artefact, in both directions and more than once. At 1.2.0 it builds 223/223 pages. At 1.7.0 it fails. Merging #115 would have shipped a docs site that cannot be built.
Two things this turned up that outlive the PR
web-docsdoes not build on macOS, onmain, unbumped. SameBase UI error #41, and the page it dies on moves between runs —hello-world, thenbuilding-currency-switcher-block, thenfchub-manifesto— which is the signature of a race, not a broken page. The container builds it reliably (3 workers there against 11 locally, so parallelism is the first suspect). The deploy is fine; local development is not, and I have not isolated the cause beyond that.docs-ci.ymlnever builds the site. It validatesversions.json, route docs, accordion structure, catalogue drift and tool counts — all content checks, nonext build. That is why a broken docs build can sit onmainunnoticed, and why the 1.7.0 bump would have been merged green. Worth adding a build step; it is the only gate that would have caught either of these.Three reverted, all for the same reason
typescript5.9.3 → 7.0.2 crashesvue-tscin thank-you (ERR_PACKAGE_PATH_NOT_EXPORTEDon./lib/tsc— a crash, not a type error) and fails the MCP build on a removed compiler option.@biomejs/biome1.9.4 → 2.5.7 rejects thank-you's v1biome.jsonschema. Each would need a config file edited to fit, which is a different job from bumping a version.Gates
MCP: 2823 unit, 404/405 tooling — the one failure is the stale gitignored
dist-packagesfixture from 31 July, absent on a runner. thank-you: builds, 23/23 phpunit; itstypecheckand biome failures were reproduced on the unmodified tree before any install, so they are inherited rather than caused. portal-extender: builds.web-docs: lint clean, catalogue in sync, container build 223/223.